Skip to content

Conversation

@Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Oct 31, 2025

Description of Changes

Host implementation to invoke call_view method.
I also covers:

  1. API MutTxId::is_materializedto check if existing view exisits and updated.
  2. Update in readsets logic to remove stale views.
  3. sql caller implmentation.

API and ABI breaking changes

NA

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
3

@Shubham8287 Shubham8287 marked this pull request as draft October 31, 2025 14:26
@Shubham8287 Shubham8287 force-pushed the shub/view-from-host branch 3 times, most recently from 1abf255 to ce0d15a Compare October 31, 2025 15:13
@Shubham8287 Shubham8287 force-pushed the shub/view-from-host branch 7 times, most recently from 564a081 to 655ab83 Compare November 4, 2025 19:35
@Shubham8287 Shubham8287 marked this pull request as ready for review November 4, 2025 19:39
@coolreader18 coolreader18 mentioned this pull request Nov 5, 2025
2 tasks
@joshua-spacetime joshua-spacetime force-pushed the joshua/drop-views-on-disconnect branch 2 times, most recently from a3987a4 to 3d7a395 Compare November 5, 2025 22:54
@Shubham8287 Shubham8287 changed the base branch from joshua/drop-views-on-disconnect to master November 6, 2025 07:05
@joshua-spacetime joshua-spacetime linked an issue Nov 6, 2025 that may be closed by this pull request
Shubham8287 and others added 9 commits November 6, 2025 14:59
Addresses -
#3487 (comment).
Can be reviewed commit wise.

1. Provide `ModuleSubscriptions` a interface to invoke
`ModuleHost::call_view`.
2. Handle `st_view_client table` insertion.
3. Make views available form sql.
@Shubham8287 Shubham8287 enabled auto-merge November 6, 2025 15:24
@joshua-spacetime joshua-spacetime changed the title Views from host Views: Host interface for WASM modules Nov 6, 2025
@Shubham8287 Shubham8287 disabled auto-merge November 6, 2025 19:36
@Shubham8287 Shubham8287 enabled auto-merge November 6, 2025 20:30
@Shubham8287 Shubham8287 added this pull request to the merge queue Nov 6, 2025
Merged via the queue into master with commit 75c6e67 Nov 6, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invoke WASM views from host

3 participants